b05c2ccbba
backend.session: rework as calloop event sources
...
Rework the Session Notifiers so that they are calloop event sources
by themselves, allowing them to be inserted by the user without the
`bind_session` dance.
Also update the logind backend to use the current dbus-rs API, rather
than the deprecated one.
2020-05-23 21:37:22 +02:00
9acd109a04
fallback: support FallbackDevice<GbmDevice, EglStreamDevice> for automatic nvidia support
2020-05-23 00:29:32 +02:00
53f5753943
udev: Add function to query the loaded driver of a device
2020-05-23 00:29:32 +02:00
69c1116d82
eglstream: initial backend implementation
2020-05-23 00:29:32 +02:00
eb1dc5de4f
egl: do not fail if desired swap interval cannot be selected
2020-05-23 00:17:19 +02:00
e8926da56c
graphics: Log underlying error of SwapBuffers
2020-05-23 00:17:19 +02:00
d3a60e03c9
egl: differenciate display creation failures
2020-05-23 00:17:19 +02:00
73447bd668
egl: Pass clonable display handle to native-impls
2020-05-23 00:17:19 +02:00
cc6e3569f0
gbm: Do not try to use eglGetDisplay
2020-05-23 00:17:19 +02:00
997895b3c7
drm: allow crate internal impls to access crtc and plane
2020-05-23 00:17:19 +02:00
f9aef43ac2
egl: move loading into separate function
2020-05-23 00:17:19 +02:00
19ef1ed3c0
egl: move eglSwapBuffers call into NativeSurface
2020-05-23 00:17:19 +02:00
0565e5fd79
egl: NativeSurface: replace recreate with create
2020-05-23 00:17:19 +02:00
0267703e91
egl: move surface creation into `NativeSurface`
2020-05-22 23:19:19 +02:00
4647141770
egl: Allow displays to specify surface_type
2020-05-22 23:19:17 +02:00
726624cbd8
egl: allow display creation to specify attributes
2020-05-22 23:18:49 +02:00
64a57a4cc8
downgrade some recoverable errors to warnings
2020-05-12 20:03:03 +02:00
9610f31e44
drm: log initial surface parameters
2020-05-12 20:03:03 +02:00
2128f68847
egl: log hidden egl errors
2020-05-12 20:03:03 +02:00
bf3e8b4d10
egl: check for surface creation failure
2020-05-12 20:03:03 +02:00
7c4ca4e524
atomic: do not revert on failing state
2020-05-12 20:03:03 +02:00
f1c40f7306
lint: fmt & clippy
2020-05-12 20:03:03 +02:00
20b373470f
drm: permission denied is also temporary
2020-05-12 19:47:16 +02:00
25f2610ea6
gbm: Do not unpack drm-rs errors on conversion
2020-05-12 19:47:16 +02:00
a0c65114fb
drm: Do not unpack drm-rs errors on conversion
2020-05-12 19:47:16 +02:00
12a57f799a
logind: ignore gone events
2020-05-12 19:47:16 +02:00
44ebed3446
gbm: only clear recreation state on successful commits
2020-05-12 19:47:16 +02:00
a6863af496
egl: force surface creation on resume
2020-05-12 19:47:16 +02:00
140185f6f5
atomic: clear invalid cursor buffers
2020-05-12 19:47:16 +02:00
163533a72a
atomic: avoid too excessive trace logging
2020-05-12 19:47:16 +02:00
b4cbecd369
atomic: do not set current state if commit fails
2020-05-12 19:47:16 +02:00
f3dabe2cea
atomic: clear broken resources on resume
2020-05-12 19:47:16 +02:00
9bbd9edb0c
egl: track backends
2020-05-12 19:47:16 +02:00
7bca463934
atomic: do not cache cursor fb info
2020-05-12 19:47:16 +02:00
1a5cc59983
drm: do not ignore events for inactive devices
2020-05-12 19:46:18 +02:00
49215f6a3d
gbm: do not implicitly restart rendering loop
2020-05-12 19:46:18 +02:00
64fc1aa0da
gbm: do not block buffer forever if commit/page_flip fails
2020-05-12 19:46:18 +02:00
0a716438e3
gbm: split out clear_framebuffers
2020-05-12 19:46:18 +02:00
eaa3a0ca87
egl: fix broken egl check
2020-05-12 19:46:18 +02:00
8f543eb597
backend.input: rework libinput as a calloop source
2020-05-12 08:46:34 +02:00
28166ce002
Merge pull request #206 from Smithay/fix/drm_connector
...
Fix drm mode and connector handling
2020-05-01 16:46:36 +02:00
26cae39598
lint: clippy
2020-05-01 16:30:11 +02:00
9300e35093
lint: fmt
2020-04-30 19:03:02 +02:00
31b6d84442
WIP: Rework egl and glium errors
2020-04-30 00:24:35 +02:00
31f1f4f9e0
backend.udev: rework as an event source
2020-04-28 11:13:25 +02:00
b3aae074e4
Update calloop to 0.6
2020-04-28 11:13:25 +02:00
6c4a3817d3
atomic: fix set_connector/mode functions
2020-04-27 21:52:30 +02:00
91b03f1e37
drm: Make DRM errors print the actual access error
2020-04-27 19:48:42 +02:00
b9201cd0b5
atomic: Make screen setting less log spamming
2020-04-27 19:48:42 +02:00
d1ac9c94db
atomic: Remove verbose property mapping from log
2020-04-27 19:48:42 +02:00
8a040630a0
fallback: Allow forcing legacy modeset via env-variable
2020-04-27 19:48:42 +02:00
5fb73a497e
gbm: cleanup session rendering loop restart
2020-04-27 19:48:42 +02:00
5e530b8263
drm: better describe add_connector usage
2020-04-27 19:48:42 +02:00
1a40ed6079
atomic: fixup rendering loop after tty switch
2020-04-27 19:48:41 +02:00
378686611c
drm: Let swap_buffers return real error
2020-04-27 19:48:41 +02:00
e486f7b87c
legacy: fixup rendering loop after tty switch
2020-04-27 19:48:41 +02:00
c7a98cee21
atomic: do not allow removal of the last connector
2020-04-27 00:45:58 +02:00
da18c3a5f3
atomic: honor dev.active
2020-04-27 00:45:58 +02:00
33149b17e2
atomic: disable connectors on surface drop
2020-04-27 00:45:58 +02:00
c560aef666
legacy: do not allow removal of the last connector
2020-04-27 00:45:58 +02:00
4786db633b
legacy: disable/enable connectors on remove/add
2020-04-27 00:45:58 +02:00
7199640ad9
legacy: honor dev.active
2020-04-27 00:45:58 +02:00
3d2e9aeff2
legacy: disable connectors on surface drop
2020-04-27 00:45:58 +02:00
d6fa2e96cf
drm: Require all surfaces to always have a mode set
2020-04-27 00:45:58 +02:00
b6087bf2d2
legacy: move create_surface into Surface constructor
2020-04-27 00:45:58 +02:00
77875f71c6
fallback: add disable_connectors to `FallbackDevice` initialization
2020-04-27 00:45:58 +02:00
50f94d013a
legacy: disable connectors on device creation
2020-04-27 00:45:58 +02:00
8c8f5e0d59
atomic: disable connectors on device creation
2020-04-27 00:45:58 +02:00
260bfd9f86
clippy fixes
2020-04-21 20:18:35 +02:00
dcd6934d08
legacy: remove outdated comment
2020-04-21 20:18:35 +02:00
11bb910224
atomic: flesh out trace logs
2020-04-21 20:18:35 +02:00
ef05dacc0d
atomic: Move out `add/map_props` to `Dev`
2020-04-21 20:18:35 +02:00
df951b5de7
common: add fallback device/surface types
2020-04-21 20:18:35 +02:00
35943fc56a
typo: ctrc -> crtc in drm/mod.rs
2020-04-21 20:18:34 +02:00
57e5494941
legacy: bugfix, add null-commit to free pipeline
2020-04-21 20:18:34 +02:00
ea44343315
drm: add set_connectors to Surface
2020-04-21 20:18:34 +02:00
d3b8563f65
gbm: Try to re-create resources and commit if restarting the rendering loop fails
2020-04-21 20:18:34 +02:00
d30bd4555e
anvil: use atomic modesetting
2020-04-21 20:18:34 +02:00
365b7e6496
drm: Add atomic modesetting support
2020-04-21 20:18:34 +02:00
e8cb940aab
drm legacy: small cleanups + additional logging
2020-04-21 20:18:34 +02:00
1b259e2deb
typo: priviledged -> privileged
2020-04-21 20:18:34 +02:00
41696f5364
drm: trigger vblank on commit
2020-04-21 20:18:34 +02:00
ed257e8991
drm: move legacy::Error into common module
2020-04-21 20:18:34 +02:00
df27224372
gbm: implement CursorBackend generically
2020-04-21 20:18:34 +02:00
cde06eb99a
cursor: simplify trait by removing barely utilized lifetimes
2020-04-21 20:18:34 +02:00
ce1b7ae8e4
Fix clippy::cognitive-complexity warning ( #198 )
...
Use helper functions in <LibinputInputBackend as InputBackend>::dipatch_new_events
to simplify the code
Move said helper functions to libinput/helpers.rs
Move libinput.rs to libinput/mod.rs
2020-04-21 14:53:59 +02:00
a5cd2978b3
Fix clippy::unnecessary::filter-map warning
2020-04-21 11:15:26 +02:00
2101f17b7b
Merge pull request #192 from Smithay/fix/primary_gpu
...
Fix primary_gpu
2020-04-18 18:26:49 +02:00
bcb2aa3864
Fix egl_to_texture check
2020-04-18 15:03:20 +02:00
39500f1d05
Fix primary_gpu
2020-04-18 13:41:54 +02:00
28eb4dd943
Fix vsync attribute
2020-04-16 16:03:10 +01:00
4b97ed8eba
Reduce choose_config complexity
2020-04-16 16:02:36 +01:00
f8c97baf1d
Prevent display being destroyed until all resources have been dropped
2020-04-16 13:44:32 +01:00
c4016af67b
Add default settings for surface creation
2020-04-16 12:33:28 +01:00
f7c05fa064
Rename WaylandEGLDisplay to EGLBufferReader
2020-04-15 21:19:20 +01:00
a4d2043b7e
Fix clippy warnings
2020-04-15 12:27:01 +01:00
3c6877f094
Fix formatting
2020-04-15 12:24:31 +01:00
b8df85e744
Mark get_proc_address as safe
2020-04-15 12:16:02 +01:00
a684f5d8d6
Refactor EGL backend
2020-04-15 12:01:01 +01:00
b54d95c15d
Fix most clippy warnings ( #185 )
...
* Add missing documentation
* Fix most clippy warnings
2020-04-15 09:28:22 +02:00
b43c0db115
Update to udev 0.4
2020-04-13 17:07:08 +02:00
6a7d933553
Replace `failure` and `error-chain` by `thiserror`
2020-04-13 13:20:59 +02:00
d92aa6dafe
Only listen to removal signal for own session ( #182 )
2020-04-12 17:00:19 +02:00
f966e28fe5
Update wayland-client & wayland-egl ( #181 )
...
Update wayland-client to 0.25.0
Add wayland-egl 0.25.0
2020-04-12 13:11:10 +02:00
f6b3d630ce
rustfmt
2020-04-10 19:18:58 +02:00
e8e8667d89
Upgrade to the upcoming drm-rs 0.4
2020-04-10 16:58:49 +02:00
e798259be9
Calculate pointer location correctly
2020-04-08 15:21:21 +02:00
3bc1c728a8
Remove excess type conversions
2020-04-08 15:21:21 +02:00
9e1bce7c66
Unhide cursor for now
2020-04-08 15:21:21 +02:00
73345375ac
Update winit dependency to version 22.0
2020-04-08 15:21:17 +02:00
178a447394
winit: Don't resize in resize handler
...
The resize handler with a window resize request causes oscillations between two window sizes (presumably the inner and the outer). While it's not clear what part of the stack causes it, checking `window.get_inner_size()` already presents the correct size.
Either way, changing the same property in its change handler is a recipe for feedback loops as this one and should be avoided whenever possible, and then carefully fortified too.
2020-04-06 10:35:27 +02:00
b8c20ebf30
Update wayland-rs to 0.25 ( #171 )
...
Update wayland-rs to 0.25 and calloop to 0.5
Co-authored-by: Victor Berger <victor.berger@m4x.org>
2020-04-05 19:01:08 +02:00
63702a308a
backend.libinput: fix tracking of removed devices
2020-04-01 11:03:54 +02:00
46348367b1
backend.egl: add egl_buffer_dimensions
...
Allows to retrieve just the dimensions, without creating images and
whatnot.
2020-02-03 12:41:35 +03:00
0140de89fb
fix some clippy warnings ( #147 )
...
This commit removes some clippy warnings (to advance #45 ) by doing the following:
- replace usage of `mem::uninitialized()` with `MaybeUninit`
- replace usage of `nix::libc::{uint64_t, int32_t}` with `{u64, i32}`
- replace functions inside of `Option::ok_or` with `Option::ok_or_else`
- replace functions inside of `Result::unwrap_or` with `Result::unwrap_or_else`
- replace occurrences of pass-by-reference with pass-by-value when
appropriate
- replace unused variables in pattern-matching with wildcards
- replace `match` expressions that have only one case with `if let`
expressions
- replace UpperCamelCase names of consts with SCREAMING_SNAKE_CASE
- remove `clone()` on types that implement Copy
- remove redundant imports
- remove `fn main()` from doctests
- remove let binding for variables that are returned afterwards
2020-01-01 11:43:16 +01:00
834f3d2e65
Upgrade to dbus 0.8, change imports to match.
2020-01-01 11:42:28 +01:00
0b2e4b42db
Fix clippy warnings with cargo fix
...
Simply ran:
```
rustup run nightly cargo fix --clippy -Z unstable-options
```
followed by
```
cargo fmt
```
No manual change in this commit.
2019-10-23 14:13:10 +02:00
c604a48dce
wayland.compositor: user UserDataMap to store per-surface data
2019-04-27 21:38:24 +02:00
9f9e6d4329
wayland.compositor: rework the subsurface tree
...
Rework the subsurface tree by:
- forbidding subsurface loops
- storing the relative depth of a parent to its children,
finally respecting the wl_subsurface specification.
closes #23
2019-04-22 17:20:46 +02:00
f34cf4b068
Upgrade anvil to wayland-server 0.23
2019-02-24 08:23:51 +01:00
3f2857fbf3
Update smithay to wayland-server 0.23
2019-02-24 08:23:51 +01:00
89dce178c8
Make wayland support optional
2019-02-06 09:29:56 +01:00
e5f8c351c7
Check for rust_2018_idioms
2018-12-16 19:31:38 +01:00
71bd64a6bf
Fix source code for 2018 edition
2018-12-16 19:31:38 +01:00
dc97e0ad03
Add reexports module
2018-12-14 14:26:50 +01:00
04aee7cbc9
Replace documentation links with intra rustdoc links
2018-12-13 15:14:25 +01:00
a3acd48cc3
fmt: rust 1.31
2018-12-08 18:31:08 +01:00
a1b8d2bf47
docs: clarify get_framebuffer_dimensions
2018-12-08 17:26:05 +01:00
c24619861e
egl: style: move constraints into where clause
2018-12-08 17:26:05 +01:00
7dc3d64b6e
docs: typo fixes
...
Co-Authored-By: Drakulix <github@drakulix.de>
2018-12-08 13:47:22 +01:00
a8343edbd7
legacy: add legacy drm example
2018-12-05 22:51:41 +01:00
bbe767002d
comments: add more explainations to new code
2018-12-05 22:48:10 +01:00
a3734da9da
gbm: update to gbm 0.5
2018-12-05 22:45:01 +01:00
8fbce616a6
libinput: update to 0.4.1
2018-12-05 22:45:01 +01:00
aa2090c079
docs: add session/multi
2018-12-05 22:45:01 +01:00
2bc45d4053
docs: fix backend_session_logind
2018-12-05 22:45:01 +01:00
36b265400a
docs: add graphics/gl
2018-12-05 22:45:01 +01:00
6609754d13
docs: add drm/egl
2018-12-05 22:45:01 +01:00
1f8a7e7335
docs: add drm/gbm
2018-12-05 22:45:01 +01:00
3b92e351b1
docs: added drm/legacy
2018-12-05 22:45:01 +01:00
174c150887
docs: added drm
2018-12-03 23:29:30 +01:00
b160a91f8a
drm: remove mode & connector arguments of create_surface
2018-12-03 23:29:30 +01:00
f8a5e8bfde
anvil: allow for non-egl builds
2018-12-03 23:29:30 +01:00
f2466c5c50
drm: Fix drop order
2018-12-03 23:29:30 +01:00
2c73651327
logind: fix dbus spamming the event queue
2018-12-03 23:29:30 +01:00
51f0050d68
drm: fix dropping master when killed from another tty
2018-12-02 22:01:45 +01:00
8abcc145d7
egl: EGLContext borrow native to circumvent RefCell runtime error
2018-12-02 22:01:45 +01:00
0ed69bf2da
session: Add multiplexer
2018-12-02 22:01:45 +01:00
5741ccdd46
gbm: fix EGLSurface recreation
2018-11-29 19:41:17 +01:00
d6e7fb591e
direct: fix udev feature name
2018-11-29 19:41:17 +01:00
e7575d08b8
gbm: fix calling lock_front_buffer without eglSwapBuffers
2018-11-29 19:41:17 +01:00
9a82de6fae
graphics: Move PixelFormat out of gl module
2018-11-29 19:41:17 +01:00
d07c66985f
gbm: CursorBackend depends on backend_drm_legacy
2018-11-29 19:41:17 +01:00
59e0ad87f9
gbm: do not expose egl support, if backend_egl is not enabled
2018-11-29 19:41:17 +01:00
de526f4b23
drm: Add functions to query device state
2018-11-29 16:13:07 +01:00
2675cf94dc
egl_surface: fix CursorBackend implementation
2018-11-29 16:13:07 +01:00
f17e37465b
drm: Remove associated Return type from Device
2018-11-29 16:13:07 +01:00
f8499e533a
libinput: fix warning when not building backend_session
2018-11-29 16:13:07 +01:00
9e5dad4c23
session: export OFlag
2018-11-29 16:13:07 +01:00
f74af7ba18
udev: use same order for bind arguments
2018-11-29 16:13:07 +01:00
9ee44672a0
cargo fmt
2018-11-29 16:13:07 +01:00
bd5690bd77
Refactor drm backend
...
- Split `DrmDevice` into `LegacyDrmDevice`, `GbmDevice` and `EglDevice`
- Provide common `Device` and `RawDevice` traits
- Change `DrmBackend` into `Surface` (and `RawSurface`) implementations of each `Device` (or `RawDevice`)
2018-11-29 16:13:07 +01:00
b537237a74
Refactor udev backend
...
- Do not open devices for `UdevHandler` anymore
- `UdevBackend` does not require `LoopHandle` or `Session` anymore
- Type of the created device can be choosed freely by the handler
- `UdevBackendObserver` is not needed anymore
2018-11-29 16:13:07 +01:00
505791e336
Upgrade backends to calloop 0.4 and renamed gl-traits
2018-11-29 16:13:05 +01:00
38ec44f70c
Hide SoftwareRenderer behind feature flag
...
- Don't let backend depend on `CursorBackend` (used to be `GraphicsBackend`) anymore
2018-11-29 16:12:11 +01:00
ccc7abc94f
Create general SwapBuffersError
2018-11-29 16:12:11 +01:00
bbf28655d1
Rename GraphicsBackend to CursorBackend
2018-11-29 16:12:11 +01:00
ac0dc42e9e
Add seperate GL module
...
- Move parts of glium & egl module into own module
- Add raw GL loader as an alternative
2018-11-29 16:12:11 +01:00
c9e67cdfef
Move egl module
...
- Remove gbm code
- rename EGLWaylandExtensions to EGLGraphicsBackend
- remove OpenGL specific code where possible
2018-11-29 16:12:11 +01:00
630b659ae6
Upgrade calloop and winit ( #114 )
...
* Fix compilation with calloop 0.4
* Use `Into` instead of changing signatures
* Bump winit to 0.18
* Fix logind for calloop 0.4
* Cargo fmt
2018-11-17 18:01:04 +01:00
734d2ce996
Fmt, spelling and capitalisation fixes ( #113 )
...
* Rename priviledged to privileged in backend/drm/mod.rs
* Fix a number of typos in comments
* Fix typos in string literals
* Wrap identifiers with backticks in doc comments
* Spelling and capitalisation in doc comments
* Use XWayland in comments
This seems to be the standard capitalisation, even though the executable
is called `Xwayland`.
* Use Glium instead of glium in comments
* Use DRM and API in comments
* Fix remaining occurrence of 'priviledged'
* Reformat code to appease Travis' rustfmt
2018-10-30 13:56:30 +01:00
9f0a1fb244
backend.winit: remove the moved() event
...
This event poses issues regarding its semantic (what space are the
coordinates in?) and arguably won't be used anyway. So let's remove it
for now, it can still be added afterwards if it appears to be really
needed.
2018-10-15 11:15:10 +02:00
df12fa4e8b
backends.winit: only expose physical sizes
...
Unify winit with the other backends in only ever dealing with physical
sizes. All dimensions and coordinates are provided in the physical space
(transformed by the dpi factor provided by winit), and the user is
responsible for dealing with the dpi scaling if they want.
A compositor using it can deal with it either by following the scaling
transmitted by the backend or using some value retrieved by other means
(like a command line argument, like weston does).
This means that a non-hidpi aware implementation will appear very small
on an hidpi screen, but not broken. This is now the current state of
anvil.
This also changes the WinitEventsHandler trait to merge the resized()
and hidpifactorchanged() callbacks into a single one, providing the
physical size and the dpi factor whenever either changes.
2018-10-15 11:15:10 +02:00
a77e29d9b5
lib: Use nested imports
2018-10-07 22:39:18 +02:00
2e9096923e
Update changelog and make the argument of `WinitEventsHandler fn moved()` a LogicalPosition
2018-09-30 19:24:13 +08:00
673f0cd0aa
Use physical size to resize egl surface and change `WinitEventsHandler fn resized()` to take a LogicalSize
2018-09-30 19:22:35 +08:00
ffdf245259
Upgrade winit backend to 0.17
2018-09-30 19:22:35 +08:00
bd08f78acd
Return the backends to the user if binding fails.
2018-09-28 18:01:33 +02:00
7f8d32429b
cargo fmt
2018-09-27 21:17:10 +02:00
6328f68b71
fix yet even more errors with logind backend
2018-09-25 11:55:30 +02:00
95d55f4b96
fix yet more errors with logind backend
2018-09-25 11:20:17 +02:00
97e960a0f1
fix more logind backend errors
2018-09-25 10:29:35 +02:00
53d27264a2
fix some logind backend errors
2018-09-25 09:44:07 +02:00
269c9a5c7c
fix doc copy/paste error
2018-09-25 09:43:49 +02:00
454f874284
cargo fmt
2018-09-25 00:32:09 +02:00
605895e30f
update to wayland-rs 0.21
2018-09-25 00:31:58 +02:00
6d31e9e5ff
address more clippy warnings
...
Not sure how much of an improvement these are.
2018-06-29 12:30:42 +02:00
4598ba0b48
address a bunch of clippy warnings
2018-06-28 11:33:49 +02:00
89764bf442
wayland.backend.egl: derive Debug for Format
2018-05-19 19:48:13 +02:00
de373074fd
Update winit to 0.14
2018-05-12 12:55:37 +02:00
422e8b33e0
backend.winit: migrate to wayland-rs 0.20
2018-04-18 09:58:32 +02:00
53242bd974
backend.libinput: migrate to wayland-rs 0.20
2018-04-18 09:53:54 +02:00
31a3d40589
backend.drm: update doc examples
2018-04-18 09:44:22 +02:00
7f6af94733
backend: migrate drm & udev
2018-04-18 09:38:35 +02:00
f9dbabce56
backend.graphics: port no-feature code to wayland-rs 0.20
2018-04-17 19:17:11 +02:00
cb4b783dc2
backend.session.logind fixes
2018-04-17 19:08:54 +02:00
b80093ffda
backend.session: migrate to wayland_rs-0.20
2018-04-17 18:39:07 +02:00
e44b0e596e
wayland.seat: migrate to wayland_rs-0.20
2018-04-15 11:55:16 +02:00
c36c511c53
[glium] Remove unnecessary mutable self reference for borrowing
2018-03-29 15:31:25 +02:00
d051e141cf
Refactor PointerAxisEvent to handle multiple axis
2018-03-22 16:10:32 +01:00
Victor Berger
Victor Brekenfeld
Sergey Smirnykh
Chandler Newman
Victor Berger
Dorota Czaplejewicz
Jonas Platte
Ivan Molodetskikh
nycex
Christophe Biocca
Pierre Chevalier
Jonas Platte
Pablo Stebler
Colin Benner
Lucas Timmins
Colin Benner