diff --git a/src/backend/renderer/gles2/mod.rs b/src/backend/renderer/gles2/mod.rs index 79f25b3..5b1a240 100644 --- a/src/backend/renderer/gles2/mod.rs +++ b/src/backend/renderer/gles2/mod.rs @@ -42,6 +42,10 @@ pub mod ffi { include!(concat!(env!("OUT_DIR"), "/gl_bindings.rs")); } +// This static is used to assign every created Renderer a unique ID (until is overflows...). +// +// This id is used to differenciate between user_data of different renderers, because one +// cannot assume, that resources between two renderers are (and even can be) shared. static RENDERER_COUNTER: AtomicUsize = AtomicUsize::new(0); #[derive(Debug)] @@ -361,6 +365,7 @@ impl Gles2Renderer { /// `EGLContext` shared with the given one (see `EGLContext::new_shared`) and can be used and destroyed on /// any of these renderers. /// - This renderer has no default framebuffer, use `Bind::bind` before rendering. + /// - Binding a new target, while another one is already bound, will replace the current target. /// - Shm buffers can be released after a successful import, without the texture handle becoming invalid. pub unsafe fn new(context: EGLContext, logger: L) -> Result where diff --git a/src/backend/renderer/mod.rs b/src/backend/renderer/mod.rs index 8d68c81..e19d344 100644 --- a/src/backend/renderer/mod.rs +++ b/src/backend/renderer/mod.rs @@ -108,6 +108,10 @@ impl From for Transform { /// Abstraction for Renderers, that can render into different targets pub trait Bind: Unbind { /// Bind a given rendering target, which will contain the rendering results until `unbind` is called. + /// + /// Binding to target, while another one is already bound, is rendering defined. + /// Some renderers might happily replace the current target, while other might drop the call + /// or throw an error. fn bind(&mut self, target: Target) -> Result<(), ::Error>; /// Supported pixel formats for given targets, if applicable. fn supported_formats(&self) -> Option> {