address more clippy warnings

Not sure how much of an improvement these are.

src/backend/drm/backend.rs

@@ -171,11 +171,11 @@ impl<A: Device + 'static> DrmBackend<A> {
             if !encoders
                 .iter()
                 .map(|encoder| encoder.possible_crtcs())
-                .all(|crtc_list| {
+                .all(|crtc_list|
                     resource_handles
                         .filter_crtcs(crtc_list)
                         .contains(&self.backend.crtc)
-                }) {
+                ) {
                 bail!(ErrorKind::NoSuitableEncoder(info, self.backend.crtc));
             }
 
@@ -473,12 +473,13 @@ impl<A: Device + 'static> GraphicsBackend for DrmBackend<A> {
 
 impl<A: Device + 'static> EGLGraphicsBackend for DrmBackend<A> {
     fn swap_buffers(&self) -> ::std::result::Result<(), SwapBuffersError> {
-        if {
+        let res = {
             let nb = self.backend.next_buffer.take();
             let res = nb.is_some();
             self.backend.next_buffer.set(nb);
             res
-        } {
+        };
+        if res {
             // We cannot call lock_front_buffer anymore without releasing the previous buffer, which will happen when the page flip is done
             warn!(
                 self.backend.logger,

src/backend/graphics/egl/native.rs

@@ -179,7 +179,7 @@ unsafe impl NativeDisplay<X11> for WinitWindow {
 
     fn create_surface(&self, _args: ()) -> Result<XlibWindow> {
         self.get_xlib_window()
-            .map(|ptr| XlibWindow(ptr))
+            .map(XlibWindow)
             .ok_or(ErrorKind::NonMatchingBackend("X11").into())
     }
 }

src/backend/session/direct.rs

@@ -177,7 +177,7 @@ impl DirectSession {
                 fcntl::OFlag::O_RDWR | fcntl::OFlag::O_CLOEXEC,
                 Mode::empty(),
             ).chain_err(|| ErrorKind::FailedToOpenTTY(String::from(path.to_string_lossy())))
-        }).unwrap_or(dup(0 /*stdin*/).chain_err(|| ErrorKind::FailedToOpenTTY(String::from("<stdin>"))))?;
+        }).unwrap_or_else(|| dup(0 /*stdin*/).chain_err(|| ErrorKind::FailedToOpenTTY(String::from("<stdin>"))))?;
 
         let active = Arc::new(AtomicBool::new(true));
 

src/wayland/seat/pointer.rs

@@ -138,7 +138,7 @@ impl PointerHandle {
     ///
     /// A single frame will group multiple scroll events as if they happended in the same instance.
     /// Dropping the returned `PointerAxisHandle` will group the events together.
-    pub fn axis<'a>(&'a self) -> PointerAxisHandle<'a> {
+    pub fn axis(& self) -> PointerAxisHandle {
         PointerAxisHandle {
             inner: self.inner.lock().unwrap(),
         }

src/xwayland/x11_sockets.rs

@@ -19,7 +19,7 @@ pub(crate) fn prepare_x11_sockets(log: ::slog::Logger) -> Result<(X11Lock, [Unix
     }
     // If we reach here, all values from 0 to 32 failed
     // we need to stop trying at some point
-    return Err(());
+    Err(())
 }
 
 pub(crate) struct X11Lock {
@@ -44,11 +44,11 @@ impl X11Lock {
                     // write to the file failed ? we abandon
                     ::std::mem::drop(file);
                     let _ = ::std::fs::remove_file(&filename);
-                    return Err(());
+                    Err(())
                 } else {
                     debug!(log, "X11 lock aquired"; "D" => display);
                     // we got the lockfile and wrote our pid to it, all is good
-                    return Ok(X11Lock { display, log });
+                    Ok(X11Lock { display, log })
                 }
             }
             Err(_) => {
@@ -79,7 +79,7 @@ impl X11Lock {
                     }
                 }
                 // if we reach here, this lockfile exists and is probably in use, give up
-                return Err(());
+                Err(())
             }
         }
     }