From 64a57a4cc84134b5b59c383191aadc8ca3e74478 Mon Sep 17 00:00:00 2001 From: Victor Brekenfeld Date: Tue, 12 May 2020 20:00:45 +0200 Subject: [PATCH] downgrade some recoverable errors to warnings --- anvil/src/glium_drawer.rs | 2 +- anvil/src/udev.rs | 8 ++++---- src/backend/drm/common/fallback.rs | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/anvil/src/glium_drawer.rs b/anvil/src/glium_drawer.rs index 24f449c..49b7301 100644 --- a/anvil/src/glium_drawer.rs +++ b/anvil/src/glium_drawer.rs @@ -473,7 +473,7 @@ pub fn schedule_initial_render( SwapBuffersError::AlreadySwapped => {} SwapBuffersError::TemporaryFailure(err) => { // TODO dont reschedule after 3(?) retries - error!(renderer.log, "Failed to submit page_flip: {}", err); + warn!(renderer.log, "Failed to submit page_flip: {}", err); let handle = evt_handle.clone(); evt_handle.insert_idle(move |_| schedule_initial_render(renderer, &handle)); } diff --git a/anvil/src/udev.rs b/anvil/src/udev.rs index 3f1b400..6f54a68 100644 --- a/anvil/src/udev.rs +++ b/anvil/src/udev.rs @@ -380,7 +380,7 @@ impl UdevHandlerImpl { |fd| match FallbackDevice::new(SessionFd(fd), true, self.logger.clone()) { Ok(drm) => Some(drm), Err(err) => { - error!(self.logger, "Skipping drm device, because of error: {}", err); + warn!(self.logger, "Skipping drm device, because of error: {}", err); None } }, @@ -388,14 +388,14 @@ impl UdevHandlerImpl { .and_then(|drm| match GbmDevice::new(drm, self.logger.clone()) { Ok(gbm) => Some(gbm), Err(err) => { - error!(self.logger, "Skipping gbm device, because of error: {}", err); + warn!(self.logger, "Skipping gbm device, because of error: {}", err); None } }) .and_then(|gbm| match EglDevice::new(gbm, self.logger.clone()) { Ok(egl) => Some(egl), Err(err) => { - error!(self.logger, "Skipping egl device, because of error: {}", err); + warn!(self.logger, "Skipping egl device, because of error: {}", err); None } }) @@ -636,7 +636,7 @@ impl DrmRenderer { } if let Err(err) = result { - error!(self.logger, "Error during rendering: {:?}", err); + warn!(self.logger, "Error during rendering: {:?}", err); let reschedule = match err { SwapBuffersError::AlreadySwapped => false, SwapBuffersError::TemporaryFailure(err) => { diff --git a/src/backend/drm/common/fallback.rs b/src/backend/drm/common/fallback.rs index e5d666e..6a47b31 100644 --- a/src/backend/drm/common/fallback.rs +++ b/src/backend/drm/common/fallback.rs @@ -191,7 +191,7 @@ impl FallbackDevice, LegacyDrmD match AtomicDrmDevice::new(fd.clone(), disable_connectors, log.clone()) { Ok(dev) => Ok(FallbackDevice::Preference(dev)), Err(err) => { - error!(log, "Failed to initialize preferred AtomicDrmDevice: {}", err); + warn!(log, "Failed to initialize preferred AtomicDrmDevice: {}", err); info!(log, "Falling back to fallback LegacyDrmDevice"); Ok(FallbackDevice::Fallback(LegacyDrmDevice::new( fd,