From 4fda0bef4a18dbb6999e841fa315c4ba453eeaa9 Mon Sep 17 00:00:00 2001 From: Victor Berger Date: Tue, 24 Apr 2018 11:00:39 +0200 Subject: [PATCH] review comments --- examples/udev.rs | 4 ++++ src/wayland/shell/legacy/mod.rs | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/udev.rs b/examples/udev.rs index f89c9ed..36adbaa 100644 --- a/examples/udev.rs +++ b/examples/udev.rs @@ -421,6 +421,10 @@ fn main() { libinput_event_source.remove(); // destroy the udev backend freeing the drm devices + // + // udev_event_source.remove() returns a Box>, downcast_impl + // allows us to cast it back to its original type, storing it back into its original + // variable to simplify type inference. udev_backend = *(downcast_impl(udev_event_source.remove()).unwrap_or_else(|_| unreachable!())); udev_backend.close(); } diff --git a/src/wayland/shell/legacy/mod.rs b/src/wayland/shell/legacy/mod.rs index d9936ab..c851410 100644 --- a/src/wayland/shell/legacy/mod.rs +++ b/src/wayland/shell/legacy/mod.rs @@ -3,7 +3,7 @@ //! This module provides automatic handling of shell surfaces objects, by being registered //! as a global handler for `wl_shell`. This protocol is deprecated in favor of `xdg_shell`, //! thus this module is provided as a compatibility layer with older clients. As a consequence, -//! you can as a compositor-writer decide to only support its fonctionnality in a best-effort +//! you can as a compositor-writer decide to only support its functionality in a best-effort //! maneer: as this global is part of the core protocol, you are still required to provide //! some support for it. //!